[OM][firtool][om-linker] Elaborate public classes before emission/after linking. #10480
Open
uenoku wants to merge 1 commit into
Open
[OM][firtool][om-linker] Elaborate public classes before emission/after linking. #10480uenoku wants to merge 1 commit into
uenoku wants to merge 1 commit into
Conversation
uenoku
force-pushed
the
dev/hidetou/eargler-property
branch
from
9cc344d to
c8c5f3c
Compare
uenoku
added a commit
that referenced
this pull request
May 16, 2026
Propagate symbol visibility from firrtl.module to om.class. Tweak mlir text syntax. Extracted from #10480. Assisted-by: augment: sonnet 4.5
uenoku
force-pushed
the
dev/hidetou/eargler-property
branch
from
c8c5f3c to
c6b92a8
Compare
Add a best-effort om-elaborate-object mode for elaborating all public OM classes. This mode leaves external objects and other unevaluated operations intact instead of treating them as errors, making it suitable for firtool’s final OM processing. Run this elaboration in firtool after om-freeze-paths so public OM classes expose frozen paths and folded object-field accesses. Preserve strict behavior for explicit target-class and test modes. Also propagate FIRRTL symbol visibility to generated OM classes during LowerClasses, so classes generated from private FIRRTL modules/classes are private as well.
uenoku
force-pushed
the
dev/hidetou/eargler-property
branch
from
b382281 to
f862400
Compare
seldridge
approved these changes
May 19, 2026
Member
seldridge
left a comment
seldridge
left a comment
There was a problem hiding this comment.
Are there any changes that need to be made to domaintool as part of this PR?
This looks great!
Comment on lines
+154
to
+155
| // Test all-public-classes mode elaborates public classes through private | ||
| // helpers, but does not elaborate private top-level classes. |
Member
There was a problem hiding this comment.
Is this missing a PUBLIC-NOT?
Member
There was a problem hiding this comment.
Nit: naming this file elaborate-error.mlir or similar would be better.
Member
Author
No, this PR and #10440 don't change a public API, so there won't be any change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a best-effort om-elaborate-object mode for elaborating all public OM classes. This mode leaves external objects and other unevaluated operations intact instead of treating them as errors, making it suitable for firtool’s final OM processing.
om-linker also runs another elaboration after linking so that properties can be used as interface contract.
This depends on #10440.
Assisted-by: augment: sonnet 4.5